Update Rubocop to 1.28.x

This is the last Ruby 2.5 compatible version.

.rubocop.yml

@@ -1,6 +1,11 @@
 inherit_from: .rubocop_todo.yml
 
+require:
+  - rubocop-performance
+  - rubocop-rake
+
 AllCops:
+  NewCops: enable
   TargetRubyVersion: 2.5
   Exclude:
     - 'test/**/*'
@@ -9,6 +14,9 @@ AllCops:
 Metrics:
   Enabled: false
 
+Gemspec/RequireMFA:
+  Enabled: false
+
 Layout/LeadingCommentSpace:
   Enabled: false
 
@@ -109,10 +117,10 @@ Style/EmptyMethod:
 Style/ParenthesesAroundCondition:
   Enabled: false
 
-Layout/AlignHash:
+Layout/HashAlignment:
   Enabled: false
 
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   Enabled: false
 
 # disabled until we can configure "+" as concat sign

Gemfile

@@ -1,6 +1,14 @@
 source 'https://rubygems.org'
 gemspec
 
+gem 'webrick'
+
+group :rubocop do
+  gem 'rubocop', '~> 1.28.0'
+  gem 'rubocop-performance'
+  gem 'rubocop-rake'
+end
+
 group :test do
   gem 'ci_reporter_test_unit'
   gem 'concurrent-ruby', '~> 1.0', require: 'concurrent'

lib/smart_proxy_dhcp_infoblox/ip_address_arithmetic.rb

@@ -9,7 +9,7 @@ def ipv4_to_i(an_address)
       an_address.split('.').inject(0) { |a, c| (a << 8) + c.to_i }
     end
 
-    def i_to_ipv4(i)
+    def i_to_ipv4(i) # rubocop:todo Naming/MethodParameterName
       (0..3).inject([]) { |a, c| a.push((i >> (c * 8)) & 0xFF) }.reverse.join('.')
     end
 

lib/smart_proxy_dhcp_infoblox/plugin_configuration.rb

@@ -10,7 +10,7 @@ def load_classes
       require 'smart_proxy_dhcp_infoblox/dhcp_infoblox_main'
     end
 
-    def load_dependency_injection_wirings(c, settings)
+    def load_dependency_injection_wirings(c, settings) # rubocop:todo Naming/MethodParameterName
       c.dependency :connection, (lambda {
         ::Infoblox.wapi_version = '2.0'
         ::Infoblox::Connection.new(:username => settings[:username], :password => settings[:password],

smart_proxy_dhcp_infoblox.gemspec

@@ -17,6 +17,4 @@ Gem::Specification.new do |s|
   s.required_ruby_version = '>= 2.5'
 
   s.add_runtime_dependency('infoblox', '~> 3.0')
-
-  s.add_development_dependency('rubocop', '~> 0.50.0')
 end