Fixes #37942 - Add job_check_mode to allow Ansible Check Mode in Job Templates #94
+11
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of Changes
This PR adds a separate
job_check_mode
variable to the AnsibleRunner class allowing Ansible Check Mode to be set on Jobs when the new ansible_check_mode checkbox is selected in Ansible Job Templates (see PR theforeman/foreman_ansible#742).Implementation Considerations
I considered re-using the existing
check_mode
variable. However, its intended use is with the ansible_roles_check_mode host parameter executing Ansible Check Mode on the "Ansible Roles" job only. Therefore, in order to not change the current expected behavior, I've separated the new functionality into a different boolean.Testing Steps
Checklists
Additional Notes
This PR is dependent on: