-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
never set REMOTE_USER to the value of SSL_CLIENT_S_DN_CN #360
Conversation
fe43bd0
to
0f8aa21
Compare
aa3490e
to
b2d793a
Compare
Do I want to know why this fails everywhere but CS9?! |
We used to, and when we introduced the current method we had to keep the old configuration around for compatibility due to N-1 Capsules. |
But wasn't this for Pulp2 stuff only? At least that's how decipher https://projects.theforeman.org/issues/35004. Anyway. Old enough to be dropped. |
^ this |
261ab13
to
2cba4e9
Compare
5bc30b7
to
7b5f0c2
Compare
03769ef
to
ddfa49f
Compare
pulpcore::apache_https_cert: '/etc/pulpcore-certs/ca-cert.pem' | ||
pulpcore::apache_https_key: '/etc/pulpcore-certs/ca-key.pem' | ||
pulpcore::apache_https_cert: '/etc/pulpcore-certs/client-cert.pem' | ||
pulpcore::apache_https_key: '/etc/pulpcore-certs/client-key.pem' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neither is truly right, but I was too lazy to crate a server-*.pem
.
If y'all think it's beneficial, I could split out the setup changes into an own PR (and add a dedicated server-cert), and then this would/could be reduced to the original "drop the CN=admin handling"? |
We only deploy a single user in Pulp: admin And we do not give out certs with CN=admin, so there is no point in trying to obtain the REMOTE_USER from the CN.
We only deploy a single user in Pulp: admin
And we do not give out certs with CN=admin, so there is no point in trying to obtain the REMOTE_USER from the CN.