Drop redundant update-ca-trust enable step #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
commented
Aug 21, 2024
| @@ -125,7 +125,6 @@ def script_template | |||
|
|
|||
| # also add the katello ca cert to the system wide ca cert store | |||
| if [ -d $CA_TRUST_ANCHORS ]; then | |||
| update-ca-trust enable | |||
| cp $CERT_DIR/$KATELLO_SERVER_CA_CERT $CA_TRUST_ANCHORS | |||
| update-ca-trust | |||
There was a problem hiding this comment.
Should this be changed to explicitly extract? Similar to voxpupuli/puppet-trusted_ca#69 (comment)
Suggested change
| update-ca-trust | |
| update-ca-trust extract |
On EL 7 & 8 the argument is ignored, so it effectively ran twice. On EL 9 since ca-certificates-0:2024.2.69_v8.0.303-91.3.el9 it does check the argument and changes behavior. The on 91.3 it hard fails on enable while 91.4 yields a deprecation warning. It still effectively runs twice. This drops the redundant step because it only needs to extract after the new CA has been added. It makes the extract step explicit, where it previously was implicit.
ekohl
force-pushed
the
drop-redundant-update-ca-trust-enable-step
branch
from
6bf8901 to
53187d9
Compare
ehelms
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On EL 7 & 8 the argument is ignored, so it effectively ran twice. On EL 9 since ca-certificates-0:2024.2.69_v8.0.303-91.3.el9 it does check the argument and changes behavior. The on 91.3 it hard fails on enable while 91.4 yields a deprecation warning. It still effectively runs twice.
This drops the redundant step because it only needs to extract after the new CA has been added.
See voxpupuli/puppet-trusted_ca#69 for a lot more context on this.