Fixes #37707 - Purge container_gateway feature without docker #488
+40
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are broken and there is a commit in #487 that fixes them. |
|
This will need a bump in |
|
This can be rebased now. |
|
Could you review theforeman/puppet-foreman_proxy#843 first? Then I can work on releasing that module. |
ekohl
force-pushed
the
37707-purge-container-gateway
branch
from
96195a7 to
909e817
Compare
puppet-pulpcore can no longer guarantee idempotency and reliably migrate the database[1]. An option[2] was introduced to pretend it's idempotent, which in upgrades may break but is good enough for CI. [1]: theforeman/puppet-pulpcore@f8d0dc6 [2]: theforeman/puppet-pulpcore@0004d05
If smart_proxy_container_gateway was already installed on a host and then enable-docker => false is used, it leaves it enabled but without Apache proxy config. On Foreman it'll also be reported as a feature. This is inconsistent. The new code ensures the feature is actually purged.
ekohl
force-pushed
the
37707-purge-container-gateway
branch
from
909e817 to
268fc30
Compare
|
Idempotency is broken because of theforeman/puppet-pulpcore#351. I opened #491 and included it here |
evgeni
approved these changes
Aug 15, 2024
| class { 'foreman_proxy_content': | ||
| pulpcore_mirror => true, | ||
| enable_docker => false, | ||
| # No Ansible repo is set up in our CI |
There was a problem hiding this comment.
what ansible repo? ansible-core is in baseos these days :)
There was a problem hiding this comment.
I copied this from another test. I'll see about dropping it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If smart_proxy_container_gateway was already installed on a host and then enable-docker => false is used, it leaves it enabled but without Apache proxy config. On Foreman it'll also be reported as a feature. This is inconsistent.
The new code ensures the feature is actually purged.
It's a draft because it relies on theforeman/puppet-foreman_proxy#843 to work properly. Otherwise it'll start to install a database and deploy the config file.