Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cleaning up mosquitto when switching to SSH #744

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Apr 22, 2022

No description provided.

@evgeni evgeni changed the title Mqtt cleanup Add support for cleaning up mosquitto when switching to SSH Apr 25, 2022
@evgeni
Copy link
Member

evgeni commented Apr 25, 2022

LGTM!

Should we add tests that this adds resources with ensure: absent for default params and explicit mode=ssh?

@evgeni evgeni mentioned this pull request Apr 28, 2022
@evgeni
Copy link
Member

evgeni commented Apr 28, 2022

@ehelms would you mind finishing this one off, so we can get it into the 22.0.0 release?

@ehelms ehelms marked this pull request as ready for review April 28, 2022 18:32
@ehelms ehelms requested a review from evgeni April 28, 2022 18:32
@evgeni evgeni merged commit 449acb8 into theforeman:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants