[REX SSH Plugin] Don't manage net-ssh-krb package #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Mar 21, 2022
wbclark
force-pushed
the
dont_install_net_ssh_krb
branch
from
ce9e578 to
8311113
Compare
wbclark
changed the title
I have made the requested change |
ekohl
reviewed
Mar 23, 2022
spec/classes/foreman_proxy__plugin__remote_execution__ssh_spec.rb
Outdated
Show resolved
Hide resolved
The package is not required since smart_proxy_remote_execution_ssh-0.5.0 and is no longer packaged in foreman repositories
wbclark
force-pushed
the
dont_install_net_ssh_krb
branch
from
8311113 to
531bec4
Compare
ekohl
approved these changes
Mar 23, 2022
This isn't quite true: https://github.com/theforeman/foreman-packaging/blob/rpm/develop/packages/plugins/rubygem-net-ssh-krb/rubygem-net-ssh-krb.spec still exists. If this is the only consumer we can actually drop it. Thinking about this change more: it's not needed since REX 0.5.0 and 3.1 (which is the minimum version according to README) ships 0.5.2. That means I'd classify this as a bugfix. However, we should be careful if we do decide to backport it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package is not required since smart_proxy_remote_execution_ssh-0.5.0
and is no longer packaged in foreman repositories