Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ACD plugin support #679

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Add ACD plugin support #679

merged 1 commit into from
Jun 11, 2021

Conversation

sbernhard
Copy link
Contributor

No description provided.

ekohl
ekohl approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me. The failure on Ubuntu 20.04 + Puppet 5 is expected.

@sbernhard
Copy link
Contributor Author

This looks correct to me. The failure on Ubuntu 20.04 + Puppet 5 is expected.

@sbernhard sbernhard closed this May 31, 2021
@sbernhard sbernhard reopened this May 31, 2021
@sbernhard sbernhard changed the title WIP: Add ACD plugin support Add ACD plugin support May 31, 2021
@maximiliankolb maximiliankolb mentioned this pull request Jun 11, 2021
Merged
@ekohl
Copy link
Member

ekohl commented Jun 11, 2021

Looks like I forgot to merge this. Thanks!

@ekohl ekohl merged commit 2f5f2f0 into theforeman:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Enhancement Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbernhard @ekohl @theforeman-bot