Remove Foreman repository parameters #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
remove-repo-params
branch
2 times, most recently
from
9967476 to
91c2ab1
Compare
This prefers that the Foreman class repo is used. The benefit is that a user doesn't end up with effectively the same repository twice. Once named foreman and once foreman_proxy, but pointing to the same URL. To keep the order consistent, it does collect the anchor that foreman::repo has which guarantees that the repo is set up before packages are installed.
ehelms
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prefers that the Foreman class repo is used. The benefit is that a user doesn't end up with effectively the same repository twice. Once named foreman and once foreman_proxy, but pointing to the same URL.
To keep the order consistent, it does collect the anchor that foreman::repo has which guarantees that the repo is set up before packages are installed.