Support Ubuntu 20.04 #669
Merged
Support Ubuntu 20.04 #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
support-ubuntu-20.04
branch
from
59ed814 to
0f87f40
Compare
|
Test failure is expected since there is no Puppet 5 package on Ubuntu 20.04. |
evgeni
approved these changes
Apr 29, 2021
This uses the fact that the tftp module uses Hiera data in modules. This allows lookup to work even if the class isn't included. It saves having to duplicate the logic. To do this, the minimum version is raised to 3.0.0 which made that change.
The most notable change is that Ubuntu 20.04 changes the tftp root from /var/lib/tftpboot to /srv/tftp. This matches Debian again. The other change is that it ships a new enough Ansible to use the callback from collections.
ekohl
force-pushed
the
support-ubuntu-20.04
branch
from
0f87f40 to
9686d75
Compare
|
Updated by raising the minimum tftp version to actually use data in modules. |
This was referenced Apr 29, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most notable change is that Ubuntu 20.04 changes the tftp root from /var/lib/tftpboot to /srv/tftp. This matches Debian again.
The other change is that it ships a new enough Ansible to use the callback from collections.
Replaces #666 & #667.