-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for external Dynflow core #512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently this is only supported on EL but would it make sense to implement this on Debian as well? Doesn't have to be the same PR, but if we have the right packages it should work and closer align the platforms.
I'm currently looking it. I most likely won't push it into this PR, but having all the platforms unified somewhere down the road would be nice. |
In that case I guess we need to have the external_core set only for el-based systems. |
That makes sense. is that a thing which needs to be done here or should it go to installer/scenarios/somewhere? |
For this question, 👍 for implementing the check here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. The dependent changes were merged in smart_proxy_dynflow and new release has been made. Ok with with getting this in as well
075d5f3
to
df73660
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the wording in comments could be improved.
Co-Authored-By: Ewoud Kohl van Wijngaarden <[email protected]>
this option is being introduced in theforeman/smart_proxy_dynflow#63