Use puppet4 functions-api #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Jan 12, 2018
|
|
||
| Puppet::Functions.create_function(:'foreman_proxy::get_network_in_addr') do | ||
| dispatch :get_network_in_addr do | ||
| required_param 'String', :addr |
There was a problem hiding this comment.
I'd prefer full names (address and netmask) for readability. Also wondering if we should use the ip address type from stdlib and remove the begin/rescue code around the IPAddr.new calls.
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
untested, but looks good 👍 |
|
merged, danke @juliantodt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy puppet3 functions-api should be avoided.
This migrates the existing function and its test to the new api and uses it in the module.