Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rh_cloud acceptance test #1206

Merged
merged 3 commits into from
Jan 23, 2025
Merged

add rh_cloud acceptance test #1206

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8eebdc2
add rh_cloud acceptance test
evgeni Jan 23, 2025
826555f
drop db between test runs, otherwise migrations might not always pass
evgeni Jan 23, 2025
3bf3b40
move repo definition to setup_acceptance_node
evgeni Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions spec/acceptance/foreman_rh_cloud_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
require 'spec_helper_acceptance'

describe 'Scenario: install foreman with rh_cloud', if: os[:family] == 'redhat' do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still wonder if this should be redhat or a list? Look at the other code that is ['debian', 'ubuntu'].include?(os[:family]).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gets executed on both CentOS Stream and Alma (I verified that), so 🤷‍♀️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the reason we drink ;)

before(:context) { purge_foreman }

it_behaves_like 'an idempotent resource' do
let(:manifest) do
<<-PUPPET
yumrepo { 'katello':
baseurl => "http://yum.theforeman.org/katello/nightly/katello/el${facts['os']['release']['major']}/x86_64/",
gpgcheck => 0,
}
yumrepo { 'candlepin':
baseurl => "https://yum.theforeman.org/candlepin/4.4/el${facts['os']['release']['major']}/x86_64/",
gpgcheck => 0,
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the repetition I'm starting to wonder if we should have a common place for this. Perhaps use katello::repo, though that still doesn't give you candlepin.

In the past I've thought about expanding foreman::repo with this, but always got stuck on the mismatch in repo version. Once we finish rpm.t.o where the versions are aligned this should be easier.

Another thing to keep in mind is that this test leaves the repository enabled, so you're already in a weird state where it may or may not be enabled during a test. If you take that logic to the extreme, it may be OK to enabled it in the spec helper at the start of the run.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I thought so too -- spec helper seems fine enogh.

Copy link
Member Author

@evgeni evgeni Jan 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to spec helper, as the acceptance tests here are not to prove our repoclosure ;-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to spec helper, as the acceptance tests here are not to prove our repoclosure ;-)

There is some aspect to this, but the installer also installs some packages in combinations that repoclosure can't quite understand. Still, I'm good with it. I even thought about moving all Katello packages into plugins to get away from the whole problem.


include foreman
include foreman::plugin::rh_cloud
PUPPET
end
end

it_behaves_like 'the foreman application'
end
1 change: 1 addition & 0 deletions spec/support/acceptance/purge.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ def purge_foreman

apache_service_name = ['debian', 'ubuntu'].include?(os[:family]) ? 'apache2' : 'httpd'
on default, "systemctl stop #{apache_service_name}", { :acceptable_exit_codes => [0, 5] }
on default, 'runuser - postgres -c "dropdb foreman"', { :acceptable_exit_codes => [0, 1, 127] }
end
Loading