Remove PR URLs when an issue is closed without merging #182
+57
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
reviewed
Sep 11, 2023
prprocessor/__main__.py
Outdated
| if pull_request['merged']: | ||
| target_branch = pull_request['base']['ref'] | ||
| version_prefix = get_version_prefix_from_branch(target_branch) | ||
| if not version_prefix: |
There was a problem hiding this comment.
version_prefix can be '' which is false-y, but still a valid prefix, I guess you wanted is not None?
evgeni
reviewed
Sep 11, 2023
This prepares for actions when it isn't merged.
ekohl
force-pushed
the
clear-redmine-on-close
branch
from
6021c37 to
1ecf91f
Compare
evgeni
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This first does some refactoring before removing PR URLs when closing a PR without merging.