Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use map to transform values in find_user_groups #84

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Use map to transform values in find_user_groups #84

merged 1 commit into from
Aug 29, 2024
+1 −5

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Aug 29, 2024

This simplifies the code by using more a expressive method, removing the need for helper variables.

@ekohl
Use map to transform values in find_user_groups
0470eaf 
This simplifies the code by using more a expressive method, removing the
need for helper variables.
adamruzicka
adamruzicka approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always wondered why it was written the way it was, I definitely won't mind not having to wonder about it anymore

@adamruzicka adamruzicka merged commit 3d11c47 into theforeman:master Aug 29, 2024
8 checks passed
@adamruzicka
Copy link
Contributor

Thank you @ekohl !

@ekohl ekohl deleted the use-more-expressive-enumerable-methods branch August 29, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekohl @adamruzicka