-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise minimum Ruby version to 2.7 #74
Conversation
1ea7c05
to
559982f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The summary of this commit should be Raise minimum Ruby version to 2.7
. Typically those kinds of changes are major version bumps.
@ekohl ah i marked it as wip and so pushed random change to check the gha workflow result for the rubocop, because rake don't have rule to check rubocop result. do you want me to work on that first? |
If it's WIP then using a draft PR makes it clear to reviewers. |
You can also override the command provided to https://github.com/theforeman/actions/blob/v0/.github/workflows/rubocop.yml. We can also change the action. I recall @evgeni mentioning something similar because you can't enable parallel testing from Rakefile. The reason I preferred the Rakefile approach in the action was that we very often had old versions of RuboCop that either didn't have the command line utility at all (that came later) or was too old to support By now I think we can start to enforce use of recent enough versions of RuboCop instead of keeping compatibility. |
559982f
to
5a24701
Compare
5a24701
to
bafff37
Compare
This needs rebase once, #75 gets merged! |
#75 includes this and passed, so merging. |
This contain changes of ruby version support, for
>= 2.7', '< 4