Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise minimum Ruby version to 2.7 #74

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

archanaserver
Copy link
Contributor

@archanaserver archanaserver commented Dec 27, 2023

This contain changes of ruby version support, for >= 2.7', '< 4

@archanaserver archanaserver force-pushed the fix-cops branch 3 times, most recently from 1ea7c05 to 559982f Compare December 27, 2023 06:56
@archanaserver
Copy link
Contributor Author

@ekohl just raised this pr to update ruby version, this was way outdated #75

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The summary of this commit should be Raise minimum Ruby version to 2.7. Typically those kinds of changes are major version bumps.

Gemfile Outdated Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
@archanaserver archanaserver changed the title Fix some cops Fix some Rubocop rules Jan 3, 2024
@archanaserver
Copy link
Contributor Author

@ekohl ah i marked it as wip and so pushed random change to check the gha workflow result for the rubocop, because rake don't have rule to check rubocop result. do you want me to work on that first?

@ekohl
Copy link
Member

ekohl commented Jan 3, 2024

If it's WIP then using a draft PR makes it clear to reviewers.

@ekohl
Copy link
Member

ekohl commented Jan 3, 2024

because rake don't have rule to check rubocop result. do you want me to work on that first?

You can also override the command provided to https://github.com/theforeman/actions/blob/v0/.github/workflows/rubocop.yml. We can also change the action. I recall @evgeni mentioning something similar because you can't enable parallel testing from Rakefile.

The reason I preferred the Rakefile approach in the action was that we very often had old versions of RuboCop that either didn't have the command line utility at all (that came later) or was too old to support --parallel.

By now I think we can start to enforce use of recent enough versions of RuboCop instead of keeping compatibility.

@ekohl ekohl marked this pull request as draft January 3, 2024 17:12
@archanaserver archanaserver changed the title Fix some Rubocop rules Raise minimum Ruby version to 2.7 Jan 9, 2024
@archanaserver
Copy link
Contributor Author

This needs rebase once, #75 gets merged!

@ekohl
Copy link
Member

ekohl commented Jan 18, 2024

#75 includes this and passed, so merging.

@ekohl ekohl merged commit 2b26441 into theforeman:master Jan 18, 2024
2 of 3 checks passed
@archanaserver
Copy link
Contributor Author

#75 includes this and passed, so merging.

Thank you @ekohl

@archanaserver archanaserver deleted the fix-cops branch January 30, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants