-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor code/tests to apply almost rubocop
rules
#60
Open
nthachus
wants to merge
15
commits into
theforeman:master
Choose a base branch
from
nthachus:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correct `Rakefile` to skip helpers while running unit-tests
- Remove unnecessary `active_support` from dependencies
- Remove unnecessary instance variables by using `config` property - Add optional parameter `only` into `find_*` methods to get one result - Refactor all unit-tests to apply almost `rubocop` rules
- Add more tests to cover almost logic cases - Optimize method `users_for_gid` to call `find_group` one-times only
… correctly - Support AD binding with an email like `username@domain` - Fix circle-loop when biding with configured `service_user` - Do not lowercase the result login / group names
- Add `attr_member` config to correct Posix LDAP groups finding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
travis
configuration to test on jRubygemspec
file to manage dependencies instead ofGemfile
vendor/bundle
pathLdapFluff
to the root of Gem lib-pathRakefile
to skip helpers while running unit-testsrubocop
configuration file to use almost rulesldap_test_helper
to the test root as a unit-test entrypointactive_support
from dependenciesis_in_groups?
touser_in_groups?
byrubocop
recommendationconfig
propertyrubocop
rulesonly
intofind_*
methods to get one result*_filter
(e.g. group_filter) to createNet::LDAP::Filter
users_for_gid
to callfind_group
one-times only