Prevent infinite recurse when 2 groups are members of each other #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,7 +20,7 @@ def _groups_from_ldap_data(payload) | |||
| data = [] | |||
| if !payload.nil? | |||
| first_level = payload[:memberof] | |||
| total_groups = _walk_group_ancestry(first_level) | |||
| total_groups, b = _walk_group_ancestry(first_level, first_level) | |||
There was a problem hiding this comment.
a) Replace b with _ if you're discarding the variable.
b) The equals signs aren't lined up any more.
c) The extra argument to _walk_group_ancestry isn't declared in its method.
|
Please also check the test failures, they appear at the moment to be because the method doesn't have a second argument defined. |
…es to solve issue already reported: theforeman#51 Fix _walk_group_ancestry method declaration with extra variable Refer unused variable with _ Lineup equals signs
|
Hi, yes, that was the reason. The tests are passed now. |
|
Great, thanks. Would you be willing to write a test for this, simulating the looped membership? If not I can add it. |
| end | ||
| end | ||
| set | ||
| return [set, known_groups] |
There was a problem hiding this comment.
nitpick, return is optional here
Style correction in return line
|
Hi, take a look. Hope it fits the purpose. |
|
Perfect, thanks @c-silva! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to solve issue already reported:
#51