Convert Smart Proxy Plugin PR testing to a pipeline #258
Conversation
ekohl
force-pushed
the
smart-proxy-pr-testing-pipeline
branch
2 times, most recently
from
5820c11 to
ddaba40
Compare
| @@ -1,40 +1,20 @@ | |||
| - job-template: | |||
| name: 'smart-proxy-{plugin}-pull-request' | |||
| name: 'smart_proxy_{plugin}-pr-test' | |||
There was a problem hiding this comment.
Renaming also helps because Jenkins can't convert a matrix job to a pipeline.
The examples were already correct, but the name itself wasn't.
ekohl
force-pushed
the
smart-proxy-pr-testing-pipeline
branch
2 times, most recently
from
ed2eec4 to
b0f85e7
Compare
|
Testing this on https://ci.theforeman.org/job/smart_proxy_dns_infoblox-pr-test/ now. |
|
So it needs some work: theforeman/smart_proxy_dns_infoblox#30. It's good work, since it brings the gem up to date and provides proper reporting of failures, but still work. |
ekohl
force-pushed
the
smart-proxy-pr-testing-pipeline
branch
from
b0f85e7 to
204abd7
Compare
| - project: | ||
| name: smart-proxy-plugin-pull-request | ||
| plugin: | ||
| - ansible |
There was a problem hiding this comment.
| - ansible | ||
| - dhcp_infoblox | ||
| - dhcp_remote_isc | ||
| - dns_infoblox |
There was a problem hiding this comment.
| name: smart-proxy-plugin-pull-request | ||
| plugin: | ||
| - ansible | ||
| - dhcp_infoblox |
There was a problem hiding this comment.
| plugin: | ||
| - ansible | ||
| - dhcp_infoblox | ||
| - dhcp_remote_isc |
There was a problem hiding this comment.
|
Generally code looks good |
|
@ehelms some Smart Proxy plugins do have Rubocop, others don't. Right now I'm going over them and add them where needed, but I wonder if we should make the pipeline aware of non-Rubocop projects by looking if |
| - monitoring | ||
| - omaha | ||
| - openscap | ||
| - pulp |
There was a problem hiding this comment.
If that makes it more flexible, and avoids having to sit on this change waiting on projects then I am all for that method. |
ekohl
force-pushed
the
smart-proxy-pr-testing-pipeline
branch
from
204abd7 to
1776737
Compare
This also renames the job names to follow the convention. It only converts projects which have been updated to be compatible.
ekohl
force-pushed
the
smart-proxy-pr-testing-pipeline
branch
from
1776737 to
625805e
Compare
|
For now I've updated it to only convert plugins which have been updated, allowing to move forward quicker. |
No description provided.