Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use theforeman-rubocop gem #10

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

archanaserver
Copy link
Contributor

Choose to inherit default.yml style because this rules have target ruby and rails version included. Also dropped some cops from here because that was either included in the inherit file or was not needed anymore and fixed some fo the cops like Rails/Date and Gemspec/RequiredRubyVersion.

default.yml: https://github.com/theforeman/theforeman-rubocop/?tab=readme-ov-file#basic-style---default-performance-and-rails-cops

This is part of Rubocop standerdization, link for the reference: https://community.theforeman.org/t/standardizing-rubocop-with-theforeman-rubocop/37239

Choose to inherit default.yml style because this rules have target ruby
and rails version included. Also dropped some cops from here because that
was either included in the inherit file or was not needed anymore and
fixed some fo the cops like Rails/Date and Gemspec/RequiredRubyVersion.
- rubocop-performance
inherit_gem:
theforeman-rubocop:
- default.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stejskalleos, we have various styles available in theforeman/theforeman-rubocop. We can select the style that closely matches the existing RuboCop rules in our repository.

After reviewing the options, found that inheriting default.yml is the best fit for hammer-cli-foreman-leapp, as it includes all the rules we currently use.

@stejskalleos stejskalleos merged commit 95972fb into theforeman:master Jul 29, 2024
4 checks passed
@stejskalleos
Copy link
Contributor

Thanks @archanaserver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants