-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use foreman-devel module #25
Conversation
So, the error is clear:
Checking the repository, I don't understand why it's failing, @ofedoren @evgeni any thoughts? |
You probably need a similar change like we had in hammer_rh_cloud here to explicitly include the locale folder: |
.packit.yaml
Outdated
@@ -29,7 +29,7 @@ jobs: | |||
trigger: pull_request | |||
targets: | |||
centos-stream-8: | |||
additional_modules: "foreman:el8" | |||
additional_modules: "foreman-devel:el8" | |||
additional_repos: | |||
- http://koji.katello.org/releases/yum/foreman-nightly/el8/x86_64/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please update this to
- http://koji.katello.org/releases/yum/foreman-nightly/el8/x86_64/ | |
- http://yum.theforeman.org/releases/nightly/el8/x86_64/ |
technically, for hammer plugins, you do not need the I think it's more correct to use it (and I'd merge this PR), but today the compilation should work with both just fine. |
And it was actually pointed out in #21:
→ once you got a new gem released, we update the packaging and things will be green here too. |
061b6f0
to
7dfecae
Compare
No description provided.