Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use foreman-devel module #25

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

nofaralfasi
Copy link
Contributor

No description provided.

@stejskalleos
Copy link
Contributor

So, the error is clear:

RPM build errors:
error: Installed (but unpackaged) file(s) found:
   /usr/share/gems/gems/hammer_cli_foreman_ansible-0.5.0/locale/en/LC_MESSAGES/hammer_cli_foreman_ansible.mo
...

Checking the repository, .mo files are correctly added in the spec file, and we don't ignore them in the .gitignore file.

I don't understand why it's failing, @ofedoren @evgeni any thoughts?

@evgeni
Copy link
Member

evgeni commented Nov 27, 2023

You probably need a similar change like we had in hammer_rh_cloud here to explicitly include the locale folder:
theforeman/foreman-packaging#9864
theforeman/foreman-packaging#9982

https://github.com/theforeman/foreman-packaging/blob/1b1d77395a48029a4b41f3e95f3cd726adfe1ff6/packages/plugins/rubygem-hammer_cli_foreman_ansible/rubygem-hammer_cli_foreman_ansible.spec#L54-L60

.packit.yaml Outdated
@@ -29,7 +29,7 @@ jobs:
trigger: pull_request
targets:
centos-stream-8:
additional_modules: "foreman:el8"
additional_modules: "foreman-devel:el8"
additional_repos:
- http://koji.katello.org/releases/yum/foreman-nightly/el8/x86_64/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please update this to

Suggested change
- http://koji.katello.org/releases/yum/foreman-nightly/el8/x86_64/
- http://yum.theforeman.org/releases/nightly/el8/x86_64/

@evgeni
Copy link
Member

evgeni commented Nov 27, 2023

technically, for hammer plugins, you do not need the foreman-devel module.

I think it's more correct to use it (and I'd merge this PR), but today the compilation should work with both just fine.

@evgeni
Copy link
Member

evgeni commented Nov 27, 2023

And it was actually pointed out in #21:

Packit fails the only fails I'm glad to observe :) indication that we finally will have translations 🤦 after we update rpmspec.

→ once you got a new gem released, we update the packaging and things will be green here too.

@stejskalleos stejskalleos merged commit 1f74b3b into theforeman:master Dec 7, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants