Retrieve the matrix base config using repos #2
+23
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
approved these changes
Oct 31, 2023
build_matrix
Outdated
Comment on lines
9
to
10
| def main(matrix, include, exclude): | ||
| matrix = json.load(matrix) |
There was a problem hiding this comment.
the one matrix is a string, the other a dict, someone gonna yell at you (→ mypy).
There was a problem hiding this comment.
That's what you get for renaming variables.
The actions/checkout action is more flexible than recreating this via URLs. It can retrieve a single file from a git clone. This is especially useful where the repository stores the same file and you want to test changes to a pipeline as well as the matrix configuration.
ofedoren
reviewed
Oct 31, 2023
| required: true | ||
| repository: | ||
| description: 'Repository to clone' | ||
| required: false |
There was a problem hiding this comment.
Optional without default value? Wouldn't it crash later?
There was a problem hiding this comment.
In testing it appears to work as I expected. I think it has a value of null and then actions/checkout does the right thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actions/checkout action is more flexible than recreating this via URLs. It can retrieve a single file from a git clone. This is especially useful where the repository stores the same file and you want to test changes to a pipeline as well as the matrix configuration.