Fixes #32014 - Expose Shellhooks as a proxy feature #25
Conversation
| @@ -0,0 +1,6 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| proxy_feature = Feature.where(name: 'Shellhooks').first_or_create | |||
There was a problem hiding this comment.
@adamruzicka , does the name make difference, i.e. 'Shellhooks' vs 'ShellHooks'?
There was a problem hiding this comment.
It can be anything as long as its lower case version matches shellhooks
There was a problem hiding this comment.
We could maybe even split it into two words
There was a problem hiding this comment.
I asked because I don't really know if the name affects anything (like some magic that loads gem by it's name or constants). Looking at other examples of exposing, this looks OK and can be merged.
There was a problem hiding this comment.
Nothing crazy like that. It gets downcased, whitespace thrown out and then it gets matched against whatever the proxy returns as its features.
There was a problem hiding this comment.
Then I guess it's safe to merge.
No description provided.