Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't pin cosmiconfig-typescript-loader anymore #909

Merged
merged 1 commit into from
Sep 30, 2024
Merged

don't pin cosmiconfig-typescript-loader anymore #909

merged 1 commit into from
Sep 30, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Sep 30, 2024

We pinned that in cc0511a to fix tests, but do not depend on it
ourself. Let's unpin and see if tests are green again.

@evgeni
don't pin cosmiconfig-typescript-loader anymore
4b124f0 
We pinned that in cc0511a to fix tests, but do not depend on it
ourself. Let's unpin and see if tests are green again.
@evgeni
Copy link
Member Author

evgeni commented Sep 30, 2024

I think it's fine since d8fb53e as we stopped using pnpm and #831 (where this pin was added) indicates it was an issue with pnpm?

@evgeni evgeni marked this pull request as ready for review September 30, 2024 15:02
@chris1984
Copy link
Member

I think it's fine since d8fb53e as we stopped using pnpm and #831 (where this pin was added) indicates it was an issue with pnpm?

Do we need this in the v10 branch as well?

@evgeni
Copy link
Member Author

evgeni commented Sep 30, 2024

I think it's fine since d8fb53e as we stopped using pnpm and #831 (where this pin was added) indicates it was an issue with pnpm?

Do we need this in the v10 branch as well?

Nah, we only do automatic package bumps in nightly, and that's where I noticed things go wrong in automation.

@chris1984
Copy link
Member

I think it's fine since d8fb53e as we stopped using pnpm and #831 (where this pin was added) indicates it was an issue with pnpm?

Do we need this in the v10 branch as well?

Nah, we only do automatic package bumps in nightly, and that's where I noticed things go wrong in automation.

Send it

@evgeni evgeni mentioned this pull request Sep 30, 2024
Closed
@chris1984 chris1984 merged commit e2ea864 into develop Sep 30, 2024
21 checks passed
@chris1984 chris1984 deleted the cosmic-sans branch September 30, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris1984 chris1984 chris1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evgeni @chris1984