Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subscription label from report slice #882

Merged
merged 1 commit into from
May 9, 2024

Conversation

chris1984
Copy link
Member

@chris1984 chris1984 commented May 4, 2024

With SCA being the default, this is now longer needed and has been removed from Katello so it throws an error in our tests

@chris1984 chris1984 requested a review from ShimShtein May 4, 2024 14:56
@chris1984
Copy link
Member Author

Tests didn't run because we don't have it enabled for this branch: https://github.com/theforeman/foreman_rh_cloud/blob/v10/.github/workflows/ruby_tests.yml#L5-L6

Should we turn it on for V10 or leave it off until we get a stable foreman branch that we want to release with?

@ShimShtein
Copy link
Member

Should we turn it on for V10 or leave it off until we get a stable foreman branch that we want to release with?

Let's test against develop and then switch to stable, once it's out.

@ShimShtein
Copy link
Member

Can you please turn the testing on, rebase and make sure the tests pass before we merge this one?

@chris1984
Copy link
Member Author

Can you please turn the testing on, rebase and make sure the tests pass before we merge this one?

Does this look familiar? https://github.com/theforeman/foreman_rh_cloud/actions/runs/8989741452/job/24693544251?pr=882

@ShimShtein
Copy link
Member

This is the commit that caused the test to fail: 32866dc
It means that we prefer RAW_POST_DATA over parameters sent to the controller. I think we should change the test accordingly

@chris1984 chris1984 merged commit 0a2fd0f into theforeman:v10 May 9, 2024
18 checks passed
@chris1984 chris1984 deleted the remove-sub branch May 9, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants