Fixes #37706 - Add a template that enables download and run of a script #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Jun 20, 2024
| required: true | ||
| %> | ||
|
|
||
| set -o pipefail && curl -sS <%= input("url") %> | bash |
There was a problem hiding this comment.
Just to be sure, I'd quote the URL because it may contain &
Suggested change
| set -o pipefail && curl -sS <%= input("url") %> | bash | |
| set -o pipefail && curl -sS '<%= input("url") %>' | bash |
.gitignore
Outdated
| @@ -15,3 +15,4 @@ Gemfile.lock | |||
| node_modules/ | |||
| package-lock.json | |||
| coverage/ | |||
| public/ | |||
There was a problem hiding this comment.
It's still needed, so split it to a separate PR.
ShimShtein
force-pushed
the
add_foreman_script_execution_template
branch
from
19e5058 to
039d0fb
Compare
|
Added quotes. |
|
@ekohl What do you think, would it be OK, or do we want to be more specific and just reuse the snippet from Foreman? |
stejskalleos
approved these changes
Aug 1, 2024
|
@ShimShtein, could you please create a RM ticket and attach it to the PR? |
ShimShtein
force-pushed
the
add_foreman_script_execution_template
branch
from
039d0fb to
ec63276
Compare
The main idea is to execute scripts from the Foreman server, similar to theforeman/foreman#10208.
ShimShtein
force-pushed
the
add_foreman_script_execution_template
branch
from
ec63276 to
2d85464
Compare
|
@ofedoren Done. |
ofedoren
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea is to execute scripts from the Foreman server, similar to theforeman/foreman#10208.