Fixes #38045 - Fix differing hidden_value variable name #744
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosas
force-pushed
the
fix-hidden-value
branch
from
2f2ada3 to
3e9d888
Compare
Thorben-D
approved these changes
Dec 3, 2024
nofaralfasi
reviewed
Dec 16, 2024
| @@ -19,3 +19,5 @@ end | |||
| node :override_values_count do |lk| | |||
| lk.lookup_values.count | |||
| end | |||
|
|
|||
| node :hidden_value, &:hidden_value? | |||
There was a problem hiding this comment.
As I mentioned here, the hidden_value does not appear to be used in this query. Could you clarify how this change impacts the functionality? I might be missing the reason why it’s necessary.
There was a problem hiding this comment.
After looking into this further, I noticed that this change only affects the API call and does not impact the GraphQL query.
nofaralfasi
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of Changes
the value for hidden_value should be the same for create and query
Implementation Considerations
Testing Steps
Component tests within this repository
Checklists
Additional Notes
SatelliteQE/nailgun#1220 (comment)