Allow GH actions and drop travis #357
Conversation
theforeman-bot
added
Waiting on contributor
Needs testing
Not yet reviewed
and removed
Waiting on contributor
labels
|
Hmm for some reason the REX feature is not in the database if the tests are being run through GH actions. |
|
I think that's the reason why I had to add I think db:create creates development and test databases, migrate and seed prepare the development database. The when you run the tests, it clones the schema of the development database, but not the data inside it, so the db is completely blank. Or at least something along the lines of this |
|
Great, that did the trick https://github.com/ezr-ondrej/foreman_ansible/actions/runs/194710574! |
|
Could you rebase please? |
|
Done 👍 |
|
I think rubocop is unhappy about this, unless codeclimate uses a different config 🤷 |
|
Hm, I've just turned that cop down as there is not a lot of certainity about it rubocop/rubocop-rails#260 |
|
I believe we are 💚 https://github.com/ezr-ondrej/foreman_ansible/actions (last two) |
|
Thank you @ezr-ondrej ! |
The cop is buggy before rubocop-rails 2.12.0 [1][2], but to get that we'd need a newer theforeman-rubocop, which generates more offenses than I am willing to fix today. Disable the cop like it was disabled in foreman_ansible too [3]. [1] rubocop/rubocop-rails#260 [2] rubocop/rubocop-rails#526 [3] theforeman/foreman_ansible#357
The cop is buggy before rubocop-rails 2.12.0 [1][2], but to get that we'd need a newer theforeman-rubocop, which generates more offenses than I am willing to fix today. Disable the cop like it was disabled in foreman_ansible too [3]. [1] rubocop/rubocop-rails#260 [2] rubocop/rubocop-rails#526 [3] theforeman/foreman_ansible#357
The cop is buggy before rubocop-rails 2.12.0 [1][2], but to get that we'd need a newer theforeman-rubocop, which generates more offenses than I am willing to fix today. Disable the cop like it was disabled in foreman_ansible too [3]. [1] rubocop/rubocop-rails#260 [2] rubocop/rubocop-rails#526 [3] theforeman/foreman_ansible#357 (cherry picked from commit 98c9fee)
rubocoplocally in the repository.Example of run: https://github.com/ezr-ondrej/foreman_ansible/actions