Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

count db:abort_if_pending_migrations as a setup rake task #9841

Merged
merged 1 commit into from
Sep 25, 2023
Merged

count db:abort_if_pending_migrations as a setup rake task #9841

merged 1 commit into from
Sep 25, 2023

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Sep 25, 2023

this avoids loading settings and friends just to check if a migration is required

ekohl
ekohl approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I first thought you'd need settings for the DB credentials, but that's a different config.

@ekohl
Copy link
Member

ekohl commented Sep 25, 2023

Can you open a Redmine issue?

@evgeni
Copy link
Member Author

evgeni commented Sep 25, 2023

sure

@evgeni
Fixes #36774 - count db:abort_if_pending_migrations as setup task
f1720c1 
this avoids loading settings and friends just to check if a migration is
required
@evgeni evgeni requested review from ekohl and removed request for ekohl September 25, 2023 14:33
@evgeni evgeni merged commit d0fcacd into theforeman:develop Sep 25, 2023
6 checks passed
@evgeni evgeni deleted the setup-abort branch September 25, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Needs re-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evgeni @ekohl