Fixes #36574 - Update fast_gettext to ~> 2.1

[ekohl]

No description provided.

[ekohl]

I needed to avoid translating during startup because it led to infinite recursion. #9771 is that PR and included here.

[ekohl]

There's another case here:

foreman/app/models/operatingsystem.rb

Line 82 in df3a0b0

apipie :class, desc: "A class representing #{model_name.human} object" do

The human method is here:
https://github.com/grosser/gettext_i18n_rails/blob/master/lib/gettext_i18n_rails/active_model/name.rb

I'll dig a bit deeper.

[ehelms]

Glad to see this getting tackled, for both Ruby / Rails reasons and to fix a conflict we've had in packaging for a while now:

Found conflict for rubygem-fast_gettext: 1.8.0 (foreman) != 2.3.0 (hammer-cli)

[ofedoren]

@ekohl, I think I found why we're not compatible with the new version of library: grosser/fast_gettext@v1.8.0...v2.0.0#diff-8798cc5941a4b48c4af929b84b9f804cbaca42547d48dc66471f7e0c4e12d1cf (lib/fast_gettext/translation.rb)

I suggest to update few things: ofedoren@eb42a44

That's not the best or prettiest way, but the logic is kinda in this. Similar changes would be needed for Foreman::Gettext::Debug as well.

[ekohl]

Thanks. Given the trace of the infinite loop I saw it makes sense. I'll see about giving it a spin. If that works, then I can also drop the 36757 commits from this PR. They'll still be good, but no longer a blocker to this PR.

[ekohl]

I tried to use include here and then it crashes. I also had the impression this file was loaded twice. At least debug appears to be:

/home/ekohl/dev/foreman/lib/foreman/gettext/debug.rb:7: warning: already initialized constant Foreman::Gettext::Debug::DL
/home/ekohl/dev/foreman/lib/foreman/gettext/debug.rb:7: warning: previous definition of DL was here
/home/ekohl/dev/foreman/lib/foreman/gettext/debug.rb:8: warning: already initialized constant Foreman::Gettext::Debug::DR
/home/ekohl/dev/foreman/lib/foreman/gettext/debug.rb:8: warning: previous definition of DR was here

So perhaps that's related to the infinite recursion.

[ofedoren]

Well, when I was checking (not debug version), I've noticed that due to changes in the library, we ended up calling our _() method instead of the lib's one due to including stuff wrongly. I don't think double loading has something to do with the recursion. Might be wrong though...

[ekohl]

In theory this is now ready, but I'd like to postpone this until after branching.

[ekohl]

We've branched twice. Let's get this in.

[ofedoren]

@ekohl, could you please fix rubocop failures? So we can see if the tests are passing at least.

[ekohl]

Updated, but didn't have time to test this myself. I'll check back what CI says after lunch.

[ofedoren]

Everything seems to be green, except that it cannot be built for some reason :/

[evgeni]

Yeah, RPM will fail as it has no 2.1 package yet.

/usr/share/rubygems/rubygems/dependency.rb:313:in `to_specs': Could not find 'fast_gettext' (~> 2.1) - did find: [fast_gettext-1.8.0] (Gem::MissingSpecVersionError)

[evgeni]

Let's see: theforeman/foreman-packaging#10515

[evgeni]

Packaging ACK

[evgeni]

@ofedoren can I get an ACK on the code? I have not the slightest idea about gettext :/

[ofedoren]

I have not the slightest idea about gettext :/

Me neither :/ But looks correct, tests are green, the app is booting and the translations are working, so I'd say GTG. Haven't tested on Ruby 2.7 though.