Fixes #35432 - Use Rails 6.1 defaults #9382
Conversation
|
Issues: #35432 |
ekohl
force-pushed
the
35432-use-rails-6.1-defaults
branch
from
4e1b791 to
648fa92
Compare
|
Quite certain test failures are related. Will need to dive into them. |
ekohl
force-pushed
the
35432-use-rails-6.1-defaults
branch
from
648fa92 to
d3b76e1
Compare
|
I've split it into multiple commits so I can dive into it and see where things break. Currently running tests on these. |
In Ruby 3.0 keyword arguments are handled separate from positional arguments[1]. This uses kwargs and passes it along. [1]: https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
Rails has introduced config.load_defaults[1] to load the defaults of a certain version. Currently this is not called at all, which means using Rails < 5.0 defaults. Changing this brings Foreman more in line with the Rails recommended defaults. [1]: https://guides.rubyonrails.org/configuring.html#versioned-default-values
Rails has introduced config.load_defaults[1] to load the defaults of a certain version. Currently this is not called at all, which means using Rails < 5.0 defaults. Changing this brings Foreman more in line with the Rails recommended defaults. [1]: https://guides.rubyonrails.org/configuring.html#versioned-default-values
ekohl
force-pushed
the
35432-use-rails-6.1-defaults
branch
from
d3b76e1 to
90d5a96
Compare
|
Rebased on #9332 now. Still need to dive into the failures. |
|
For encryption I think it the requirements on the key may have been tightened. The key looks to be md5 (they are always 32 characters): foreman/test/unit/encryptable_test.rb Line 17 in 06600bc Perhaps updating this to a stronger key is sufficient. As for the interface validation errors, I don't know. I wish the errors were less vague. |
|
Thank you for your contribution, @ekohl! This PR has been inactive for 3 months, closing for now. |
|
Thank you for your contribution, @ekohl! This PR has been inactive for 3 months, closing for now. |
Rails has introduced config.load_defaults to load the defaults of a certain version. Currently this is not called at all, which means using Rails < 5.0 defaults. Changing this brings Foreman more in line with the Rails recommended defaults.
Right now this is a draft since I'm a bit uncertain of all the implications.