-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #28422 - use jest instead of jest-cli #7230
Conversation
Issues: #28422 |
Removing the
VS
According to jest docs:
|
@amirfefer can you rebase? |
@@ -8,7 +8,7 @@ | |||
"lint": "./node_modules/.bin/eslint -c .eslintrc webpack/ script/", | |||
"foreman-js:link": "./script/npm_link_foreman_js.sh", | |||
"postlint": "./script/npm_lint_plugins.js", | |||
"test": "node --max_old_space_size=8192 node_modules/.bin/jest --no-cache --config config/jest.config.js", | |||
"test": "jest --config config/jest.config.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is absolutely amazing !
with cache:
tests on first run: 160 seconds,
on second time: 80 seconds,
on third time: 40 seconds,
on 4th time: 18 seconds
merged, thanks @amirfefer! |
in foreman core we use
jest-cli
for testing, but in plugins, we use regular jestdue to moving it to
@foreman/env
we should keep it unified