Fixes #37746 - Update to pf5 #10272

MariaAga · 2024-08-13T13:14:38Z

Needs theforeman/foreman-js#481 & to remove pf5 from package.json
Will need plugin updates as well.
For testing with the foreman-js PR, you will need to add

    "@patternfly/patternfly": "^5.2.0",
    "@patternfly/react-charts": "^5.2.0",
    "@patternfly/react-core": "^5.2.0",
    "@patternfly/react-icons": "^5.2.0",
    "@patternfly/react-styles": "^5.2.0",
    "@patternfly/react-table": "^5.2.0",
    "@patternfly/react-tokens": "^5.2.0",

to foreman/package.json

foreman and foreman-js need to be in the pf5 branch
in the foreman dir bundle exec rake assets:clobber rm -rf public/webpack node_modules package-lock.json npm i --legacy-peer-deps
in the foreman-js npm run clean npm i --legacy-peer-deps NODE_OPTIONS=--openssl-legacy-provider npm run build npm run link
and then in the foreman dir bundle exec foreman start (or start webpack )

webpack/assets/javascripts/react_app/common/colors.scss

package.json

kmalyjur

Except for a few small things I commented on (and some not successful checks), everything looks fine, thank you! 🥳

app/assets/stylesheets/base-pf4.scss

app/assets/stylesheets/patternfly_colors_overrides.scss

webpack/assets/javascripts/react_app/components/HostDetails/Audits/index.js

webpack/assets/javascripts/react_app/components/HostDetails/DetailsCard/index.js

...ssets/javascripts/react_app/components/HostDetails/Tabs/Details/Cards/TemplatesCard/index.js

...assets/javascripts/react_app/components/HostDetails/Templates/CardItem/CardTemplate/index.js

...sets/javascripts/react_app/components/Layout/components/TaxonomySwitcher/TaxonomyDropdown.js

webpack/assets/javascripts/react_app/components/PF4/TableIndexPage/Table/Table.js

webpack/assets/javascripts/react_app/components/SearchBar/SearchAutocomplete.js

kmalyjur · 2024-11-22T17:54:39Z

webpack/assets/javascripts/react_app/components/PF4/TableIndexPage/Table/Table.js

+    return [
      isDeleteable && {
        title: __('Delete'),
        onClick: () => onDeleteClick({ id, name }),
-        isDisabled: !canDelete,
+        isAriaDisabled: !canDelete,
      },
-      ...((getActions &&
-        getActions({ id, name, canDelete, canEdit, ...item })) ??
-        []),
+      ...extendActions.map(action => ({
+        ...action,
+        isAriaDisabled: action.isDisabled,
+      })),
    ].filter(Boolean);
+  };


The functionality is fine, however, when opening the table kebab, the "Edit" button looks like it's selected and the mouse on the "Change content..." looks like it's clickable:

Fixed both, thanks

MariaAga · 2024-11-26T13:54:13Z

Thanks @kmalyjur for the review, all should be fixed now. I'll open a seperate PR for host page

The pencil icon is not clickable when the table is too small, but that issue was already there before, so it's not in the scope of this PR

kmalyjur

Thank you! I'm just not sure about some of the not-passing checks, but I'm certain you'll figure it out :)

MariaAga · 2024-11-27T14:07:20Z

webpack/assets/javascripts/react_app/components/HostsIndex/index.js

@@ -281,6 +281,7 @@ const HostsIndex = () => {
        window.location.href = foremanUrl(`/hosts/${id}/clone`);
      },
      isDisabled: !canEdit,
+      autoFocus: true,


Need to remove

MariaAga · 2024-11-27T17:42:04Z

The checks are mostly failing due to this PR not having the correct foreman-js version, which will only be available once the foreman-js PR is merged. and also will need to do a packaging PR

sjha4 · 2025-01-07T18:41:49Z

Functionally this has been working well on foreman and katello pages..Ack on this outside of dependency related CI issues..

sjha4

The pages are loading correctly and all the pages look good from everything I tested..Changes make sense for the upgrade..Ack.. 👍🏼

MariaAga · 2025-01-10T15:02:57Z

Updated PR to include new components that were added in the last 5 months

evgeni · 2025-01-15T12:58:06Z

package.json

-    "tabbable": "~5.2.0",
+    "tabbable": "^6.2.0",


Note to self: this doesn't need packaging.

evgeni · 2025-01-15T12:59:01Z

package.json

+    "@patternfly/patternfly": "^5.1.0",
+    "@patternfly/react-charts": "^7.3.0",
+    "@patternfly/react-core": "^5.1.1",
+    "@patternfly/react-icons": "^5.1.1",
+    "@patternfly/react-styles": "^5.1.1",
+    "@patternfly/react-table": "^5.1.1",
+    "@patternfly/react-tokens": "^5.1.1",


@MariaAga do you need help packaging those?

or will it be vendored inside foreman-js and we won't need packaging these separately?

It will be inside foreman-js

okay, so the change here is just temporarily until there is a foreman-js release out with those changes? and we don't package tabbable, so you technically don't need any packaging ACK ;-)
(GH will still want it, so, once there is a foreman-js release out, and the version requirement was bumped here, you get it)

Yes, thanks

ogajduse · 2025-01-15T12:59:15Z

@theforeman/packaging

ekohl · 2025-01-15T14:04:13Z

Do I get it right that this adds patternfly 5, but doesn't remove any older version? So now we have yet another front end framework in place?

MariaAga · 2025-01-15T15:28:28Z

@ekohl

Do I get it right that this adds patternfly 5, but doesn't remove any older version? So now we have yet another front end framework in place?

Nope, it removes it in foreman-js "Needs theforeman/foreman-js#481 & to remove pf5 from package.json"

pr-processor bot added Not yet reviewed Waiting on contributor labels Aug 13, 2024

github-actions bot added the UI label Aug 13, 2024

MariaAga force-pushed the pf5-update branch from b38bad1 to c0a810a Compare August 13, 2024 15:50

MariaAga commented Aug 19, 2024

View reviewed changes

webpack/assets/javascripts/react_app/common/colors.scss Outdated Show resolved Hide resolved

pr-processor bot removed the Not yet reviewed label Aug 19, 2024

MariaAga commented Aug 20, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

pr-processor bot added the Needs re-review label Sep 6, 2024

MariaAga force-pushed the pf5-update branch from 31359e3 to d0f6fed Compare September 6, 2024 13:55

pr-processor bot removed the Waiting on contributor label Sep 6, 2024

This was referenced Sep 6, 2024

Fixes #37747 - Update to Patternfly 5 theforeman/foreman_ansible#735

Open

Fixes #37748 - Update to Patternfly 5 theforeman/foreman_bootdisk#166

Open

Fixes #37749 - Update to Patternfly5 theforeman/foreman_discovery#641

Open

MariaAga marked this pull request as ready for review September 6, 2024 14:03

MariaAga requested a review from a team as a code owner September 6, 2024 14:03

This was referenced Sep 6, 2024

Fixes #37750 - Update to Patternfly 5 theforeman/foreman_remote_execution#919

Open

Fixes #37751 - Update to Patternfly 5 theforeman/foreman-tasks#758

Open

Update to Patternfly5 theforeman/foreman_rh_cloud#899

Open

MariaAga force-pushed the pf5-update branch from d0f6fed to 1e2fd6f Compare September 10, 2024 14:07

MariaAga changed the title ~~PF5~~ Fixes #37746 - Update to pf5 Sep 13, 2024

kmalyjur suggested changes Nov 22, 2024

View reviewed changes

pr-processor bot added Waiting on contributor and removed Needs re-review labels Nov 22, 2024

MariaAga force-pushed the pf5-update branch from 1e2fd6f to 7300ea9 Compare November 25, 2024 16:08

pr-processor bot added Needs re-review and removed Needs re-review labels Nov 25, 2024

MariaAga force-pushed the pf5-update branch from 7300ea9 to c263844 Compare November 26, 2024 13:52

pr-processor bot added Needs re-review and removed Needs re-review labels Nov 26, 2024

kmalyjur approved these changes Nov 27, 2024

View reviewed changes

MariaAga commented Nov 27, 2024

View reviewed changes

MariaAga force-pushed the pf5-update branch from c263844 to 1b26f3e Compare November 28, 2024 15:04

pr-processor bot added the Needs re-review label Nov 28, 2024

MariaAga force-pushed the pf5-update branch 2 times, most recently from 23a04ac to 4339a09 Compare January 7, 2025 11:04

github-actions bot added the Legacy JS PRs making changes in the legacy Javascript stack label Jan 7, 2025

sjha4 approved these changes Jan 8, 2025

View reviewed changes

pr-processor bot removed the Needs re-review label Jan 8, 2025

MariaAga added 2 commits January 10, 2025 14:48

Fixes #37746 - Update to pf5

7e25ab3

review fixes

b33b5e0

MariaAga force-pushed the pf5-update branch from 4339a09 to b33b5e0 Compare January 10, 2025 15:02

pr-processor bot added the Needs re-review label Jan 10, 2025

evgeni reviewed Jan 15, 2025

View reviewed changes

package.json

Comment on lines -60 to +67

"tabbable": "~5.2.0",

"tabbable": "^6.2.0",

Copy link

Member

evgeni Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: this doesn't need packaging.

pr-processor bot removed the Needs re-review label Jan 15, 2025

evgeni reviewed Jan 15, 2025

View reviewed changes

ekohl mentioned this pull request Jan 21, 2025

Fixes #37382 - Update to jQuery 3 #10138

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #37746 - Update to pf5 #10272

Fixes #37746 - Update to pf5 #10272

MariaAga commented Aug 13, 2024 •

edited

Loading

kmalyjur left a comment •

edited

Loading

kmalyjur Nov 22, 2024

MariaAga Nov 26, 2024

MariaAga commented Nov 26, 2024

kmalyjur left a comment

MariaAga Nov 27, 2024

MariaAga commented Nov 27, 2024

sjha4 commented Jan 7, 2025

sjha4 left a comment

MariaAga commented Jan 10, 2025

evgeni Jan 15, 2025

evgeni Jan 15, 2025

evgeni Jan 15, 2025

MariaAga Jan 15, 2025

evgeni Jan 15, 2025

MariaAga Jan 15, 2025

ogajduse commented Jan 15, 2025

ekohl commented Jan 15, 2025

MariaAga commented Jan 15, 2025

Fixes #37746 - Update to pf5 #10272

Are you sure you want to change the base?

Fixes #37746 - Update to pf5 #10272

Conversation

MariaAga commented Aug 13, 2024 • edited Loading

kmalyjur left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MariaAga commented Nov 26, 2024

kmalyjur left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MariaAga commented Nov 27, 2024

sjha4 commented Jan 7, 2025

sjha4 left a comment

Choose a reason for hiding this comment

MariaAga commented Jan 10, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ogajduse commented Jan 15, 2025

ekohl commented Jan 15, 2025

MariaAga commented Jan 15, 2025

MariaAga commented Aug 13, 2024 •

edited

Loading

kmalyjur left a comment •

edited

Loading