Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37636 - remove usage of "@theforeman/test" #10239

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

MariaAga
Copy link
Member

@MariaAga MariaAga commented Jul 9, 2024

Working towards removing theforeman/test, context: https://community.theforeman.org/t/do-we-want-to-keep-foreman-js/37644
had to do all 3 in one pr since:
[Fixes #37636 - remove "@theforeman/test" imports] - relying on jest config having resolved foremanReact into a valid path, otherwise I would have had to use relative path instead and thats too much work

[Fixes #37637 - Test plugins from foreman core] - for some reason npm lint needs @theforeman/test package, so it was easier to stop using it instead of working around it. left some of the theforeman eslint packages to remove later, as this commit only deals with whats necessary to get lint to work after removing theforeman/test

.eslintrc turned into script/lint/lint_core_config.js, no changes except for formatting

@github-actions github-actions bot added the UI label Jul 9, 2024
@MariaAga MariaAga force-pushed the remove-foreman-test-import branch from ce4011b to bd82e9d Compare July 9, 2024 12:59
@MariaAga MariaAga marked this pull request as draft July 9, 2024 13:22
@MariaAga MariaAga force-pushed the remove-foreman-test-import branch 10 times, most recently from 915675e to f2c89fd Compare July 15, 2024 13:27
@MariaAga MariaAga force-pushed the remove-foreman-test-import branch 15 times, most recently from b37548d to f757e1d Compare July 17, 2024 14:23
@MariaAga MariaAga force-pushed the remove-foreman-test-import branch 4 times, most recently from 0382a92 to 49acfba Compare July 18, 2024 16:12
@MariaAga MariaAga force-pushed the remove-foreman-test-import branch 2 times, most recently from 2be51ef to 91d4309 Compare July 18, 2024 18:34
@MariaAga MariaAga force-pushed the remove-foreman-test-import branch from 91d4309 to a249de8 Compare September 11, 2024 15:27
script/npm_test_plugin.js Outdated Show resolved Hide resolved
webpack/jest.config.js Outdated Show resolved Hide resolved
webpack/theforeman-test.js Outdated Show resolved Hide resolved
script/lint/plugin-lint.js Outdated Show resolved Hide resolved
@MariaAga MariaAga changed the title Fixes #37636 - remove "@theforeman/test" imports Fixes #37636 - remove usage of "@theforeman/test" Sep 13, 2024
@MariaAga MariaAga force-pushed the remove-foreman-test-import branch 2 times, most recently from c12831e to 2f92ad0 Compare September 17, 2024 12:16
const fs = require('fs');
const path = require('path');

function linkEslintPlugin(runPath = process.cwd()) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check npm link

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm link too complicated (need package.json with specific naming, deletes files sometimes) while creating a symlink is simple.

@MariaAga MariaAga force-pushed the remove-foreman-test-import branch from 2f92ad0 to 727a769 Compare October 30, 2024 14:41
"path-browserify": "^1.0.1",
"prettier": "^1.19.1",
"pretty-format": "26.6.2",
"react-dnd-test-backend": "^9.4.0",
"react-redux-test-utils": "^0.2.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@MariaAga MariaAga marked this pull request as ready for review October 30, 2024 19:21
@MariaAga MariaAga requested a review from a team as a code owner October 30, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant