feat(vendor-core): update to jquery 3 #479
Conversation
There was a problem hiding this comment.
Out of interest, why pin to these specific versions instead of a wider range? And would the latest jquery version work?
There was a problem hiding this comment.
Good point, I'm not sure why I used that version, gonna run some tests and update this
There was a problem hiding this comment.
updated, had to do one small change for the in the core pr as focusout was removed
|
Moved to using js-cookie directly instead of from the jquery module theforeman/foreman#10250 |
packages/vendor-core/package.json
Outdated
| "jquery-ujs": "~1.2.0", | ||
| "jquery.cookie": "~1.4.1", | ||
| "js-cookie": "3.0.0", |
There was a problem hiding this comment.
Do we need this here if foreman core depends on it? I'm not sure where we are with the whole removal of foreman-js.
There was a problem hiding this comment.
nope, forgot to remove it. removed now. were still using foreman-js
BREAKING CHANGE: Updates jquery,datatables,select2. removes jquery.cookie
|
I don't feel qualified to review this given how little I've done in the frontend but would love to see progress on this. How can we get this merged? Is it something we want in this cycle? So merge it this month? Do we need to coordinate with various plugins? |
|
@ekohl were waiting for @sjha4 or @jeremylenz to review it |
BREAKING CHANGE:
Updates jquery,datatables,select2. replaces jquery.cookie with js-cookie