Update GitHub actions and gem versions #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was already done previously because 3.0 as a float is just 3, but now it's explicit.
bastelfreak
reviewed
Jan 20, 2025
| - name: Setup ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: 3.0 | ||
| ruby-version: 3 |
There was a problem hiding this comment.
will that use the latest 3.x release? Don't you want a specific minor release like "3.4"?
There was a problem hiding this comment.
I wasn't sure. I kind of like just using the latest since then we don't need to update it. I'd rather spend time fixing compatibility with the latest than to keep some value up to date. Our use of modulesync is also really light.
There was a problem hiding this comment.
it already does, as 3.0 is not a string, but a float, which is… 3, so that change is just making it more explicit
There was a problem hiding this comment.
Exactly what I wrote in my commit message :)
evgeni
approved these changes
Jan 20, 2025
bastelfreak
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details.