drop stagingyum from rsync config #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
May 6, 2024
Yes, because the "server" also serves other paths. But I read https://github.com/puppetlabs/puppetlabs-rsync/blob/main/manifests/server/module.pp in a way that the concat fragment is now gone and thus it gets removed from rsyncd.conf |
evgeni
force-pushed
the
drop-stagingyum-rsync
branch
from
b0382bf to
66150d0
Compare
ekohl
approved these changes
May 7, 2024
| @@ -62,7 +62,6 @@ | |||
| contain web::vhost::yum | |||
|
|
|||
| class { 'web::vhost::stagingyum': | |||
There was a problem hiding this comment.
If you don't set parameters, the contain below is sufficient because it implies including the class. Note we do the same with web::vhost::stagingdeb.
evgeni
force-pushed
the
drop-stagingyum-rsync
branch
from
66150d0 to
68d996d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.