Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves 2333 "Specify Puppet version requirement" #2551

Merged
merged 7 commits into from
Oct 26, 2023
Merged

Resolves 2333 "Specify Puppet version requirement" #2551

merged 7 commits into from
Oct 26, 2023

Conversation

maximiliankolb
Copy link
Contributor

@maximiliankolb maximiliankolb linked an issue Oct 24, 2023 that may be closed by this pull request
Installation guides state Puppet 5 is the minimum version #2333
Closed
@maximiliankolb
Copy link
Contributor Author

After review and merging, we think which commits to cherry-pick, and which to cherry-pick and adapt to ensure that "Foreman version <-> supported Puppet version(s)" matches.

@github-actions
Copy link

github-actions bot commented Oct 24, 2023 •
edited
Loading

The PR preview for b3de125 is available at theforeman-foreman-documentation-preview-pr-2551.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@maximiliankolb
Reword supported version of Puppet
87ad7ee
@maximiliankolb
Add missing colon after list item
d77fd1a
@maximiliankolb
Use SmartProxyServer attribute
a9ac78b 
* Help differentiate between internal Smart Proxy and external Smart
  Proxy Server
* Order options in alphabetical order
@maximiliankolb
Only use puppet7-repo
12077c6 
For Katello users, they cannot use "latest" because that would be Puppet
Agent for Puppet 8. See https://www.puppet.com/docs/puppet/8/services_agent_unix#services_agent_unix
@maximiliankolb
Remove Puppet requirement from Quickstart guide
601010c
@maximiliankolb
Use one sentence per line
78608b4
@maximiliankolb maximiliankolb force-pushed the 2333-puppet-version-master branch from 182dad6 to 78608b4 Compare October 25, 2023 14:58
maximiliankolb
maximiliankolb commented Oct 25, 2023
View reviewed changes
Copy link
Contributor Author

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied feedback and rebased to master.

guides/common/modules/ref_supported-puppet-versions-and-system-requirements.adoc Outdated Show resolved Hide resolved
guides/doc-Quickstart/master.adoc Outdated Show resolved Hide resolved
mjivraja
mjivraja suggested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@mjivraja mjivraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last and Rest looks good.

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author Needs re-review and removed Not yet reviewed Waiting on contributor Requires an action from the author labels Oct 26, 2023
mjivraja
mjivraja approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@mjivraja mjivraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!.

guides/doc-Quickstart/master.adoc Outdated Show resolved Hide resolved
@maximiliankolb maximiliankolb force-pushed the 2333-puppet-version-master branch from bf222a0 to b3de125 Compare October 26, 2023 06:51
@maximiliankolb maximiliankolb requested a review from ekohl October 26, 2023 07:11
@maximiliankolb maximiliankolb merged commit 32abaea into theforeman:master Oct 26, 2023
8 checks passed
@maximiliankolb maximiliankolb deleted the 2333-puppet-version-master branch October 26, 2023 08:34
This was referenced Oct 26, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjivraja mjivraja mjivraja approved these changes

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installation guides state Puppet 5 is the minimum version
3 participants
@maximiliankolb @ekohl @mjivraja