Keep preventDefault during Carousel transition. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clicking prev / next during a slide transition appends the carousel tag to the URL as there's no event handlers to call e.preventDefault(). Possibly jarring to user experience as the carousel jumps to page top.
|
Hey, thanks for the contribution. I had something like this in mind and I ended up with the current code and the reason for that is also the click handlers for page navigation (you know the dots) need a way to disable/prevent being clicked. I would prefer a better solution and more simple: while animating, remove all click handlers for all carousel children. |
|
Please download and test latest commit. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking prev / next during a slide transition appends the carousel tag to the URL as there's no event handlers to call e.preventDefault().
Possibly jarring to user experience as the carousel jumps to page top.