tab: Fix error when no dropdown is used with tabs #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is no dropdown being used as a tab self.dropdown is null. This results in an error when attempting to test/set the active class on the null dropdown variable. This bug was introduced in commit "Removed `classList` dependency " 7acaaac...
|
Here is the line in the old code that checks if self.dropdown is present: |
thednp
added a commit
that referenced
this pull request
Jan 21, 2016
tab: Fix error when no dropdown is used with tabs
|
Thank you for the catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no dropdown being used as a tab self.dropdown is null. This
results in an error when attempting to test/set the active class on the null
dropdown variable.
This bug was introduced in commit "Removed
classListdependency " 7acaaac...