Add modal fade option

[schorke]

Added the fade option in modal, default is set to true to not break the current behaviour.

[thednp]

You want to add true/false to the class?

[schorke]

I wanted to add the ability to remove the "fade" class on the <div class="modal-backdrop fade"></div> by changing newOverlay[setAttribute]('class',modalBackdropString+' fade'); to newOverlay[setAttribute]('class', modalBackdropString + (self[animation] ? ' fade' : ''));.

[thednp]

@schorke I think an "auto" mode would suffice much better. Think about this:

if (hasClass(modal,'fade')) // also add fade class to the backdrop

We don't change the original plugin options while adding a simple fail safe mechanism, all without developer having to remember "one more thing".

What do you think?

[schorke]

I don't understand the "auto mode". How / where do you set or remove the fade ?

[thednp]

Basically we change this

this[animation] = options[animation] === false || modal[getAttribute](animation) === 'false' ? false : true;

to this

this[animation] = hasClass(modal,'fade') ? true : false;

@schorke what do you think?

[schorke]

Ok, now I understand !

Yeah, I think your solution is better : keeping it out of options and managed by class ! I'll update my PR. 👍

[thednp]

This will require additional tinkering for the case when opening another modal from a currently opened modal. The first example of our demo shows that the <div id="anotherModal> with/without the fade class will hide the backdrop.

[thednp]

Done. Please download latest master and give it a try, I'm interested in the modal original events and opening modal from another modal.