-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to not include the Data API initialization code #214
Conversation
We would also need this stuff for V3 as well, also some documentation update should also be taken into account. |
If you agree on the implementation like this and want to potentially merge
it, then I'd happily take a look at v3 and the docs..?
Op vr 11 mei 2018 19:30 schreef thednp <[email protected]>:
… We would also need this stuff for V3 as well, also some documentation
update should also be taken into account.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#214 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAZkqI3rEfMDghqwyq_kbYftFRvg9bEEks5txcqugaJpZM4T7d_p>
.
|
I would rename the option to |
I changed the option to Lastly, I updated the wiki page with the new option but reverted it again since this PR is not merged yet (you can see it in the history what I wanted to change). Let me know if there is anything else you need to get this merged. |
@thednp Awesome, thanks! Could you build and publish a new version to NPM so I can use it? |
@marcelpanse you can use latest master in your |
I can't since I'm using webpack-bootstrap.native-loader which has a NPM
dependency on bootstrap.native.
Also you should publish because now the wiki docs are out of sync with the
latest published version, which is confusing.
Op vr 11 mei 2018 23:28 schreef midzer <[email protected]>:
… @marcelpanse <https://github.com/marcelpanse> you can use latest master
in your package.json by putting thednp/bootstrap.native in your
bootstrap.native version field.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#214 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAZkqMUkej-5yRud6gYAQCNrhlImgvZMks5txgKPgaJpZM4T7d_p>
.
|
I added a note on the wiki page, please confirm it's validity. Thanks |
Looks good :-)
Op za 12 mei 2018 10:00 schreef thednp <[email protected]>:
… I added a note on the wiki page
<https://github.com/thednp/bootstrap.native/wiki/How-to-use>, please
confirm it's validity. Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#214 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAZkqCiWd_1xf1jklql1PUTm02noxwXEks5txpa0gaJpZM4T7d_p>
.
|
One more thing: what would be the most common use cases for this implementation? I'm thinking about mentioning those in the wikies as well. |
If you are making a component that can be included on any page (like a widget/bar/popup/carousel/etc) then you'd want that component to be as small as possible but still have the benefits of using the Bootstrap components, so you use bootstrap.native. |
We use bootstrap native to build a component. This component can be used on our clients' websites by including our javascript file. As soon as they include our library, bootstrap-native will start searching the entire DOM tree to find data- elements and start initializing them. This will have unintended side-effects. We only want to initialize our own inserted DOM elements programmatically, so I added an option to exclude the utils-init.js code.
This solved #180