Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3: in someEl.Tab.show(), next was undefined #142

Closed
wants to merge 1 commit into from

Conversation

rloth
Copy link

@rloth rloth commented Jul 6, 2017

Hello !
When I tried to used the show() from tab-native, it complained that next was undefined, so here is my fix for you to consider.
Thanks for the general work on bootstrap-native it's a very useful project for me.
RL

@thednp
Copy link
Owner

thednp commented Jul 6, 2017

I cannot confirm the issue, do you perhaps have a test page?

@thednp thednp added the invalid not related or critical label Jul 6, 2017
@rloth
Copy link
Author

rloth commented Jul 6, 2017

For me it came up by trying the stock example from https://thednp.github.io/bootstrap.native/#componentTab but perhaps it's affected by other vars in the page... I'll see if I can reproduce it on a page with only this and keep you posted after my office hours.

@thednp
Copy link
Owner

thednp commented Jul 6, 2017

I think I know why this could potentially happen. First, next is defined with the clickHandler, but if you use the show() method via JavaScript, it's not going to be defined. I will make proper fixes asap.

I think next = next || element; should do.

Thanks for the report.

@thednp thednp closed this Jul 6, 2017
@thednp
Copy link
Owner

thednp commented Jul 6, 2017

Please test the latest master and let me know how it works.

@thednp thednp added enhancement potential improvement and removed invalid not related or critical labels Jul 6, 2017
rloth added a commit to moma/ProjectExplorer that referenced this pull request Jul 6, 2017
@rloth
Copy link
Author

rloth commented Jul 6, 2017

Yes indeed it was direct js use so next was undefined.
Now next = next || element does fix it ! (tested with your latest V3...)
thanks for the quick action :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement potential improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants