Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal auto-hide breaks #265

Closed
sergeymorkovkin opened this issue Jan 14, 2019 · 8 comments
Closed

Modal auto-hide breaks #265

sergeymorkovkin opened this issue Jan 14, 2019 · 8 comments
Assignees
Labels
bug critical issue

Comments

@sergeymorkovkin
Copy link

Create two modals, do NOT use data API, call show() on the first modal, the call show() on the second. The script will break.

@thednp
Copy link
Owner

thednp commented Jan 14, 2019

You mean call both at the same time? Open the second before first finishes the show animation?

@sergeymorkovkin
Copy link
Author

No, I mean consequently, not both at a time.

@thednp
Copy link
Owner

thednp commented Jan 14, 2019

The first example showcases the use of consequently opening modals, no issues there. You mean you call the second modal via JS myModal.show()?

@sergeymorkovkin
Copy link
Author

Exactly. Same example, with pure JS and no Data API, as I mentioned.

@thednp
Copy link
Owner

thednp commented Jan 14, 2019

You have a test site?

@sergeymorkovkin
Copy link
Author

Not yet, sorry.

thednp added a commit that referenced this issue Jan 14, 2019
* fixing #265, a known issue left unchecked
* documentation updates to reflect the improvement
thednp added a commit that referenced this issue Jan 14, 2019
* fixing #265, a known issue left unchecked
* documentation updates to reflect the improvement
@thednp
Copy link
Owner

thednp commented Jan 14, 2019

@sergeymorkovkin please download latest master and give it a spin. Also check documentation updates.

Thanks for reporting and have fun.

@thednp thednp closed this as completed Jan 14, 2019
@thednp thednp added the bug critical issue label Jan 14, 2019
@sergeymorkovkin
Copy link
Author

Confirm. Worked perfectly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug critical issue
Projects
None yet
Development

No branches or pull requests

2 participants