Closing modal with escape key prevents it from showing again

[Gazler]

It appears that there is an issue with closing the modal using the escape key on version 4. I know there are a few issues related to modal display issues, so perhaps it is a regression of some sort?

To trigger the issue, open a modal, press escape, then try opening the modal again. The modal should display, then immediately disappear.

For convenience, here is a script to replicate it on the demo application:

http://thednp.github.io/bootstrap.native/

var el = document.querySelector('button[data-target="#myModal"]'); 
el.click(); 
setTimeout(() => {
  var e = new Event("keydown"); 
  e.keyCode = 27; 
 document.dispatchEvent(e)
}, 300); 
setTimeout(() => {el.click()}, 1000)

We have also observed this behaviour with clicking on the backdrop to dismiss, and via a data-dismiss attribute.

[thednp]

I cannot duplicate the issue, works for me on Windows 10 with EDGE, Opera, Chrome and Firefox.

Are you on a MAC?

[Gazler]

I'm on Linux (Ubuntu), a colleague also on Linux (Arch Linux) was able to replicate. Will try a different OS to see if I can replicate.

Have tried Chrome and Firefox.

[midzer]

Can't duplicate, too. I close via ESC key and can open modal again.

(using debian testing, latest chromium)

[ktec]

Able to replicate the behaviour on a Mac using Chrome by the following:

1. Visit http://thednp.github.io/bootstrap.native/
2. Click the modal button, it works as expected.
3. Open dev tools. Run the script:

var el = document.querySelector('button[data-target="#myModal"]'); el.click(); setTimeout(() => {var e = new Event("keydown"); e.keyCode = 27; document.dispatchEvent(e)}, 300);

4. Now when you click the Modal button it consistently shows then disappears.

HTH

[ktec]

Able to replicate on Arch / Chrome too.

[thednp]

Do you guys have a console error?

[Gazler]

Here's a recording of it triggering including the console (using the code snippet from the original issue.)

[Gazler]

I was also able to replicate on EDGE, chrome and Firefox on Windows 10 with the script above.

[thednp]

Let me get this right. Are you telling me that you've written a script to loop an "open-close" and proves our component is doing things wrong? I mean our script isn't bullet proof in that scenario, I don't think any script is.

[Gazler]

No, it is easily triggered manually, the script is just an easy way to replicate the issue.

…

On Mon, 19 Nov 2018, 20:24 thednp ***@***.*** wrote: Let me get this right. Are you telling me that you've written a script to loop an "open-close" and proves our component is doing things wrong? I mean our script isn't bullet proof in that scenario, I don't think any script is. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#256 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAdJRw2qzL-YkNRgHmZEcfamCLVvtltpks5uwxN3gaJpZM4Yph-6> .

[thednp]

I will have a look at this asap, I think the ESC KEY event handler should be scheduled to start later.

Thanks for reporting.

[thednp]

@Gazler please test the latest master, demo page also updated.