-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.modal-open class not removed when closing modal quickly #125
Comments
Thanks for the find, will look into it asap. UPDATE: I cannot replicate. Do you have a test site and/or perhaps some console errors? |
@adibbz ? |
@thednp Do you have a email or way to contact you privately? Don't want to share dev link publicly. |
@adibbz the |
@thednp so were you able to build and push this up today? |
I am almost there, this got me to a point I found some new unresolved cases, incredibly, with the tabs... |
@adibbz please download latest master and do some testing. |
@thednp Removing fade class resolved the body scroll issue. Thank you! |
Also make sure to test the other components I mentioned, they've been changed to support this functionality. |
I have multiple modals on a page and whenever I open one and close it quickly by either the
.close
button or clicking outside the modal the.modal-open
class does not get removed from thebody
preventing me form scrolling my page.I've also added
data-backdrop="static"
to the modal so it can only be dismissed by the.close
button but this also is not removing the.modal-open
class. It also appears it is not removing the inlinedisplay: block
from the modal and simply changing the opacity back to 0.Any ideas of what I might be having an issue with?
The text was updated successfully, but these errors were encountered: