Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.modal-open class not removed when closing modal quickly #125

Closed
adibbz opened this issue Apr 11, 2017 · 9 comments
Closed

.modal-open class not removed when closing modal quickly #125

adibbz opened this issue Apr 11, 2017 · 9 comments
Assignees
Labels
enhancement potential improvement
Milestone

Comments

@adibbz
Copy link

adibbz commented Apr 11, 2017

I have multiple modals on a page and whenever I open one and close it quickly by either the .close button or clicking outside the modal the .modal-open class does not get removed from the body preventing me form scrolling my page.

I've also added data-backdrop="static" to the modal so it can only be dismissed by the .close button but this also is not removing the .modal-open class. It also appears it is not removing the inline display: block from the modal and simply changing the opacity back to 0.

Any ideas of what I might be having an issue with?

@thednp
Copy link
Owner

thednp commented Apr 11, 2017

Thanks for the find, will look into it asap.

UPDATE: I cannot replicate. Do you have a test site and/or perhaps some console errors?

@thednp thednp self-assigned this Apr 11, 2017
@thednp thednp added the invalid not related or critical label Apr 11, 2017
@thednp
Copy link
Owner

thednp commented Apr 12, 2017

@adibbz ?

@adibbz
Copy link
Author

adibbz commented Apr 12, 2017

@thednp Do you have a email or way to contact you privately? Don't want to share dev link publicly.

@thednp thednp added enhancement potential improvement and removed invalid not related or critical labels Apr 12, 2017
@thednp
Copy link
Owner

thednp commented Apr 12, 2017

@adibbz the fade class is now optional for Modal, working as expected. Will also implement this feature for Alert, Tab, Tooltip and Popover components. Both V3 and V4. As soon as the build is done, will commit to git, and I will need you to do some testing on your site.

@thednp thednp added this to the 2.0.10 milestone Apr 12, 2017
@adibbz
Copy link
Author

adibbz commented Apr 13, 2017

@thednp so were you able to build and push this up today?

@thednp
Copy link
Owner

thednp commented Apr 13, 2017

I am almost there, this got me to a point I found some new unresolved cases, incredibly, with the tabs...

thednp added a commit that referenced this issue Apr 19, 2017
* Alert, Modal, Tooltip, Popover, Tab components now can work without the `fade` class, details #125
* Fixing #126
thednp added a commit that referenced this issue Apr 19, 2017
* Alert, Modal, Tooltip, Popover, Tab components now can work without the `fade` class, details #125
* Fixing #126
@thednp
Copy link
Owner

thednp commented Apr 19, 2017

@adibbz please download latest master and do some testing.

@adibbz
Copy link
Author

adibbz commented Apr 19, 2017

@thednp Removing fade class resolved the body scroll issue. Thank you!

@thednp
Copy link
Owner

thednp commented Apr 19, 2017

Also make sure to test the other components I mentioned, they've been changed to support this functionality.

@thednp thednp closed this as completed Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement potential improvement
Projects
None yet
Development

No branches or pull requests

2 participants