Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion - "collapsed" Class not added to the toggle link when opening a different Panel. #122

Closed
mgrixti opened this issue Mar 21, 2017 · 3 comments
Assignees
Labels
enhancement potential improvement
Milestone

Comments

@mgrixti
Copy link

mgrixti commented Mar 21, 2017

Using Version: 2.0.7 (Bootstrap 3)

When there is an open panel and you click a different panel's toggle link, it will close the open panel but it does not add the "collapsed" class to the toggle link. When you click the toggle link of the current open panel it does add the collapsed class to the toggle link.

The official Bootstrap Collapse/Accordion does add the "collapsed" class when clicking a different panel's toggle link.

You can inspect/compare the accordions in the documentation for Bootstrap Native and Official Bootstrap to see an example of the bug in action. When you click an unopened panel, you can see it does not add the "collapse" class to the toggle link of the open panel that gets closed upon opening a different panel.

Bootstrap Native Accordion: https://thednp.github.io/bootstrap.native/#accordion
Bootstrap Official Accordion: http://getbootstrap.com/javascript/#accordion

@thednp
Copy link
Owner

thednp commented Mar 21, 2017

I'll have a look into it asap. Thanks

@thednp thednp added the enhancement potential improvement label Mar 21, 2017
@thednp thednp added this to the 2.0.8 milestone Mar 21, 2017
@thednp thednp closed this as completed in 6c9aa16 Mar 21, 2017
thednp added a commit that referenced this issue Mar 21, 2017
@thednp
Copy link
Owner

thednp commented Mar 21, 2017

@mgrixti Please test latest master and let me know how it goes.

@mgrixti
Copy link
Author

mgrixti commented Mar 21, 2017

@thednp That fixed it. Thanks for fixing it so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement potential improvement
Projects
None yet
Development

No branches or pull requests

2 participants