Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover position #105

Closed
c01nd01r opened this issue Jan 27, 2017 · 6 comments
Closed

Popover position #105

c01nd01r opened this issue Jan 27, 2017 · 6 comments
Assignees
Labels
bug critical issue enhancement potential improvement
Milestone

Comments

@c01nd01r
Copy link

Hi!
I looked modal component on the demo site and I think Popover have wrong positioning.
Look at this screencast https://youtu.be/crzMnjpX7-w

@thednp
Copy link
Owner

thednp commented Jan 27, 2017

I tested on my phone and it's working as expected. Either the Chrome emulator is wrong OR the Chrome emulator injects the document into another kind of invisible <iframe> and the component will compute the position based on the root document and not the one in the <iframe>. Same goes for Tooltip.

Next time, test on your phone first.

@thednp thednp closed this as completed Jan 27, 2017
@thednp thednp added the invalid not related or critical label Jan 27, 2017
@c01nd01r
Copy link
Author

Ok, I tested it on my Android 7.1 and Chrome 55.0.2883.91
https://drive.google.com/file/d/0BwZyHEp890XdMG5pNzJBYTI1S2c/view?usp=sharing
Nothing has changed

@thednp
Copy link
Owner

thednp commented Jan 27, 2017

Oh I see. Well, our Popover and Tooltip components have no handler for touch events.

I am now thinking of 2 possible ways:

  • we either close the tooltip on scroll/touchmove
  • or we create a new handler to update the position on scroll/tochmove

@thednp
Copy link
Owner

thednp commented Jan 27, 2017

This must be related to the changes needed to make it work for SVGs

@thednp thednp reopened this Jan 27, 2017
@thednp
Copy link
Owner

thednp commented Jan 27, 2017

OK I will look into it and hopefully provide a fix ASAP.

Thanks for reporting.

thednp added a commit that referenced this issue Jan 27, 2017
thednp added a commit that referenced this issue Jan 27, 2017
@thednp
Copy link
Owner

thednp commented Jan 27, 2017

Ok please test the new code, demo and docs updated and report back any other issues. I will release as soon as you confirm it works. In my tests everything is perfect.

FYI: you need to set data-container="#myModal" for your tooltips/popovers in order to work properly in your modals.

@thednp thednp added bug critical issue and removed invalid not related or critical labels Jan 27, 2017
@thednp thednp closed this as completed Jan 27, 2017
@thednp thednp added the enhancement potential improvement label Jan 27, 2017
@thednp thednp self-assigned this Jan 27, 2017
@thednp thednp added this to the 2.0.1 milestone Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug critical issue enhancement potential improvement
Projects
None yet
Development

No branches or pull requests

2 participants