Merge pull request #253 from chaitanyagupta/fix-tab-clicks

OK let's go ahead with this, I tested with most browsers and seems to be fine.
thednp · Dec 3, 2018 · 36e44f6 · 36e44f6
2 parents c32f747 + 84409df
commit 36e44f6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/lib/V4/tab-native.js b/lib/V4/tab-native.js
@@ -99,10 +99,9 @@ var Tab = function( element, options ) {
     },
     // handler 
     clickHandler = function(e) {
-      var href = e[target][getAttribute]('href');
+      var href = e[currentTarget][getAttribute]('href');
       e[preventDefault]();
-      next = e[target][getAttribute](dataToggle) === component || (href && href.charAt(0) === '#')
-           ? e[target] : e[target][parentNode]; // allow for child elements like icons to use the handler
+      next = e[currentTarget];
       !tabs[isAnimating] && !hasClass(next,active) && self.show();
     };
 

diff --git a/lib/V4/utils.js b/lib/V4/utils.js
@@ -50,7 +50,7 @@ var globalObject = typeof global !== 'undefined' ? global : this||window,
 
   // option keys
   backdrop = 'backdrop', keyboard = 'keyboard', delay = 'delay',
-  content = 'content', target = 'target',
+  content = 'content', target = 'target', currentTarget = 'currentTarget',
   interval = 'interval', pause = 'pause', animation = 'animation',
   placement = 'placement', container = 'container',