-
-
Notifications
You must be signed in to change notification settings - Fork 178
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* added JSDoc for all files * added strong TypeScript definitions * Fixed some issue with `Offcanvas` not removing the overlay * fixed an issue with `Dropdown`, focusing in after hiding the dropdown menu * added an `Component.getInstance` static method to all components * added components data like the original, requires doc updates * added `defaults`, `name` and `version` methods to all components * reworked the `initCallback` and `removeDataApi` * all components expose an initialization method * code cleanup @fmasa please take a minute and check the TypeScript definitions whenever you get some time, report back anything wrong, this commit is dedicated to YOU!
- Loading branch information
Showing
202 changed files
with
15,673 additions
and
2,965 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,5 @@ package-lock.json | |
.npmignore | ||
.vscode/ | ||
node_modules/ | ||
local/ | ||
demo.html |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
.vscode/ | ||
assets/ | ||
node_modules/ | ||
local/ | ||
CONTRIBUTING.md | ||
package-lock.json | ||
index.html | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
273a861
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thednp The types are great now 😮 Thank you very much!
The only thing that could be improved is types of some boolean arguments, such as 273a861#diff-961ded9e3d59514d6afb993f49c7fd2152561ceb2cabfaf3e5cec6a13bda6bfbR394
We can probably just use
boolean
instead ofboolean | number
to be a bit more strict. I was honestly confused as to what does providing numbers meant there as I expected some special behavior. I can submit PR to fix these few occurrences, if you want. 🙂273a861
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm considering that as well.
273a861
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My work right now is focused on the
bootstrapCustomEvent
utility, I don't know how to make it output a specific component. I don't know much TypeScript to do the magic it needs.